So I did the lower control arms about two weeks ago and car was rideing smooth for a week or maybe ten days than a similar noise occurs but only on the left hand drivers side , car is not feeling right and my instructor at my mechanic school is saying to replace drivers side upper control arm / ball joint now any tips or suggestions I would greatly appreciate thanks a lot guys !

You did the lower control arms that the air strut base sits on or the front tension arms?
a easy way to check the upper control arms is to jack up the car and try to move the suspect wheel in a vertical motion. One hand on top and another on bottom and try to see if there is any play. Usually upper control arms with make noise as your moving the wheel. Also double check everything you have taken off last time.